Skip to content

provider: fix codex native provider name - #3

Merged
duoyuli merged 1 commit into
mainfrom
session/d3e01c47
Jun 15, 2026
Merged

duoyuli merged 1 commit into
mainfrom
session/d3e01c47

Conversation

@duoyuli

@duoyuli duoyuli commented Jun 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 15, 2026 05:00
@duoyuli
duoyuli merged commit e96c047 into main Jun 15, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures Codex proxy provider profiles written by arc-kit always use Codex’s expected native provider identifier (name = "OpenAI"), while still selecting the desired profile via the arc provider profile name.

Changes:

  • Update Codex config writer to persist a fixed native provider name value ("OpenAI") for proxy profiles.
  • Adjust/add tests to validate the written Codex TOML and auth JSON behavior (including a CLI black-box test).
  • Document the behavior in README and the user guides (EN + zh-CN).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Documents that Codex proxy providers keep native name fixed to OpenAI.
docs/user/guide.md Adds the same rule to the English user guide.
docs/user/guide.zh-CN.md Adds the same rule to the Chinese user guide.
arc-core/src/provider/codex.rs Writes Codex proxy provider name as a fixed "OpenAI" constant.
arc-core/tests/provider_tests.rs Updates the Codex config-writing test expectation to "OpenAI".
arc-cli/tests/provider_codex_config.rs Adds an integration test ensuring CLI provider use writes native name as "OpenAI" and sets OPENAI_API_KEY.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants