provider: fix codex native provider name - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Ensures Codex proxy provider profiles written by arc-kit always use Codex’s expected native provider identifier (name = "OpenAI"), while still selecting the desired profile via the arc provider profile name.
Changes:
- Update Codex config writer to persist a fixed native provider
namevalue ("OpenAI") for proxy profiles. - Adjust/add tests to validate the written Codex TOML and auth JSON behavior (including a CLI black-box test).
- Document the behavior in README and the user guides (EN + zh-CN).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents that Codex proxy providers keep native name fixed to OpenAI. |
| docs/user/guide.md | Adds the same rule to the English user guide. |
| docs/user/guide.zh-CN.md | Adds the same rule to the Chinese user guide. |
| arc-core/src/provider/codex.rs | Writes Codex proxy provider name as a fixed "OpenAI" constant. |
| arc-core/tests/provider_tests.rs | Updates the Codex config-writing test expectation to "OpenAI". |
| arc-cli/tests/provider_codex_config.rs | Adds an integration test ensuring CLI provider use writes native name as "OpenAI" and sets OPENAI_API_KEY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.