Update dependency urllib3 to v2.2.2 [SECURITY]#32
Closed
renovate[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
0420f95 to
42ab779
Compare
42ab779 to
ded7f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==2.0.2->==2.2.2GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
CookieHTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookieheader and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookieheader, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookieheader on requests, which is mostly typical for impersonating a browser.Remediation
redirects=Falsewhen sending requests.Cookieheader.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST) toGETas is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False.redirects=Falseand handle 303 redirects manually by stripping the HTTP request body.CVE-2024-37891
When using urllib3's proxy support with
ProxyManager, theProxy-Authorizationheader is only sent to the configured proxy, as expected.However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the
Proxy-Authorizationheader even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat theProxy-AuthorizationHTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the
Proxy-Authorizationheader during cross-origin redirects to avoid the small chance that users are doing this on accident.Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the
Proxy-Authorizationheader, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Proxy-Authorizationheader without using urllib3's built-in proxy support.Remediation
Proxy-Authorizationheader with urllib3'sProxyManager.redirects=Falsewhen sending requests.Proxy-Authorizationheader.Release Notes
urllib3/urllib3 (urllib3)
v2.2.2Compare Source
==================
Proxy-Authorizationheader to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect.amtto read methods ofhttp.client.HTTPResponseas an alternative toNone. (#​3122 <https://github.com/urllib3/urllib3/issues/3122>__)typing.Self. (#​3363 <https://github.com/urllib3/urllib3/issues/3363>__)v2.2.1Compare Source
==================
InsecureRequestWarningwas emitted for HTTPS connections when using Emscripten. (#​3331 <https://github.com/urllib3/urllib3/issues/3331>__)HTTPConnectionPool.urlopento stop automatically casting non-proxy headers toHTTPHeaderDict. This change was premature as it did not apply to proxy headers andHTTPHeaderDictdoes not handle byte header values correctly yet. (#​3343 <https://github.com/urllib3/urllib3/issues/3343>__)InvalidChunkLengthtoProtocolErrorwhen response terminates before the chunk length is sent. (#​2860 <https://github.com/urllib3/urllib3/issues/2860>__)ProtocolErrorto be more verbose on incomplete reads with excess content. (#​3261 <https://github.com/urllib3/urllib3/issues/3261>__)v2.2.0Compare Source
==================
Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html>, including streaming support in cross-origin isolated browser environments where threading is enabled. (#​2951 <https://github.com/urllib3/urllib3/issues/2951>)HTTPResponse.read1()method. (#​3186 <https://github.com/urllib3/urllib3/issues/3186>__)#​3284 <https://github.com/urllib3/urllib3/issues/3284>__)when using proxy. (
#​2244 <https://github.com/urllib3/urllib3/issues/2244>__)HTTPConnection.proxy_is_verifiedandHTTPSConnection.proxy_is_verifiedto be always set to a boolean after connecting to a proxy. It could be
Nonein some cases previously. (#​3130 <https://github.com/urllib3/urllib3/issues/3130>__)headerspassed in a request withjson=would be mutated (#​3203 <https://github.com/urllib3/urllib3/issues/3203>__)HTTPSConnection.is_verifiedto be set toFalsewhen connectingfrom a HTTPS proxy to an HTTP target. It was set to
Truepreviously. (#​3267 <https://github.com/urllib3/urllib3/issues/3267>__)#​3268 <https://github.com/urllib3/urllib3/issues/3268>__)#​3325 <https://github.com/urllib3/urllib3/issues/3325>__)time with the
--integrationpytest flag. (#​3181 <https://github.com/urllib3/urllib3/issues/3181>__)v2.1.0Compare Source
==================
#​2680 <https://github.com/urllib3/urllib3/issues/2680>__)#​2681 <https://github.com/urllib3/urllib3/issues/2681>__)#​3143 <https://github.com/urllib3/urllib3/issues/3143>__)#​3065 <https://github.com/urllib3/urllib3/issues/3065>__)x-gzipcontent-encoding. (#​3174 <https://github.com/urllib3/urllib3/issues/3174>__)v2.0.7Compare Source
==================
v2.0.6Compare Source
==================
Cookieheader to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect.v2.0.5Compare Source
==================
#​3126 <https://github.com/urllib3/urllib3/issues/3126>__)blocksizeofHTTPConnectionclasses to match high-level classes. Previously was 8KiB, now 16KiB. (#​3066 <https://github.com/urllib3/urllib3/issues/3066>__)v2.0.4Compare Source
==================
HTTPHeaderDict(#​2254 <https://github.com/urllib3/urllib3/issues/2254>__)BaseHTTPResponsetourllib3.__all__(#​3078 <https://github.com/urllib3/urllib3/issues/3078>__)urllib3.connection.HTTPConnectionto raise thehttp.client.connectaudit event to have the same behavior as the standard library HTTP client (#​2757 <https://github.com/urllib3/urllib3/issues/2757>__)#​3087 <https://github.com/urllib3/urllib3/issues/3087>__)v2.0.3Compare Source
==================
#​3020 <https://github.com/urllib3/urllib3/issues/3020>__)#​2950 <https://github.com/urllib3/urllib3/pull/2950>_)#​3008 <https://github.com/urllib3/urllib3/issues/3008>__)assert_hostname=Falseto correctly skip hostname check. (#​3051 <https://github.com/urllib3/urllib3/issues/3051>__)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.