Skip to content

Parameterize order creation SQL #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-agentic-autofix wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parameterize order creation SQL #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5530f5
Initial plan
Sep 29, 2026
af52a73
Parameterize order creation SQL
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 74 additions & 59 deletions WebGoat.NET/Data/OrderRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Globalization;
using System.Threading;

namespace WebGoatCore.Data
{
Expand All @@ -25,66 +23,83 @@ public Order GetOrderById(int orderId)
}

public int CreateOrder(Order order)
{
Thread.CurrentThread.CurrentCulture = new CultureInfo("en-US");
// These commented lines cause EF Core to do wierd things.
// Instead, make the query manually.

// order = _context.Orders.Add(order).Entity;
// _context.SaveChanges();
// return order.OrderId;

string shippedDate = order.ShippedDate.HasValue ? "'" + string.Format("yyyy-MM-dd", order.ShippedDate.Value) + "'" : "NULL";
var sql = "INSERT INTO Orders (" +
"CustomerId, EmployeeId, OrderDate, RequiredDate, ShippedDate, ShipVia, Freight, ShipName, ShipAddress, " +
"ShipCity, ShipRegion, ShipPostalCode, ShipCountry" +
") VALUES (" +
$"'{order.CustomerId}','{order.EmployeeId}','{order.OrderDate:yyyy-MM-dd}','{order.RequiredDate:yyyy-MM-dd}'," +
$"{shippedDate},'{order.ShipVia}','{order.Freight}','{order.ShipName}','{order.ShipAddress}'," +
$"'{order.ShipCity}','{order.ShipRegion}','{order.ShipPostalCode}','{order.ShipCountry}')";
sql += ";\nSELECT OrderID FROM Orders ORDER BY OrderID DESC LIMIT 1;";

using (var command = _context.Database.GetDbConnection().CreateCommand())
{
command.CommandText = sql;
_context.Database.OpenConnection();

using var dataReader = command.ExecuteReader();
dataReader.Read();
order.OrderId = Convert.ToInt32(dataReader[0]);
}

sql = ";\nINSERT INTO OrderDetails (" +
"OrderId, ProductId, UnitPrice, Quantity, Discount" +
") VALUES ";
foreach (var (orderDetails, i) in order.OrderDetails.WithIndex())
{
orderDetails.OrderId = order.OrderId;
sql += (i > 0 ? "," : "") +
$"('{orderDetails.OrderId}','{orderDetails.ProductId}','{orderDetails.UnitPrice}','{orderDetails.Quantity}'," +
$"'{orderDetails.Discount}')";
}

if (order.Shipment != null)
{
var shipment = order.Shipment;
shipment.OrderId = order.OrderId;
sql += ";\nINSERT INTO Shipments (" +
"OrderId, ShipperId, ShipmentDate, TrackingNumber" +
") VALUES (" +
$"'{shipment.OrderId}','{shipment.ShipperId}','{shipment.ShipmentDate:yyyy-MM-dd}','{shipment.TrackingNumber}')";
}

using (var command = _context.Database.GetDbConnection().CreateCommand())
{
command.CommandText = sql;
_context.Database.OpenConnection();
command.ExecuteNonQuery();
}

{
using (var command = _context.Database.GetDbConnection().CreateCommand())
{
command.CommandText = @"INSERT INTO Orders (
CustomerId, EmployeeId, OrderDate, RequiredDate, ShippedDate, ShipVia, Freight, ShipName, ShipAddress,
ShipCity, ShipRegion, ShipPostalCode, ShipCountry
) VALUES (
@CustomerId, @EmployeeId, @OrderDate, @RequiredDate, @ShippedDate, @ShipVia, @Freight, @ShipName,
@ShipAddress, @ShipCity, @ShipRegion, @ShipPostalCode, @ShipCountry
);
SELECT OrderID FROM Orders ORDER BY OrderID DESC LIMIT 1;";
AddParameter(command, "@CustomerId", order.CustomerId);
AddParameter(command, "@EmployeeId", order.EmployeeId);
AddParameter(command, "@OrderDate", order.OrderDate);
AddParameter(command, "@RequiredDate", order.RequiredDate);
AddParameter(command, "@ShippedDate", order.ShippedDate);
AddParameter(command, "@ShipVia", order.ShipVia);
AddParameter(command, "@Freight", order.Freight);
AddParameter(command, "@ShipName", order.ShipName);
AddParameter(command, "@ShipAddress", order.ShipAddress);
AddParameter(command, "@ShipCity", order.ShipCity);
AddParameter(command, "@ShipRegion", order.ShipRegion);
AddParameter(command, "@ShipPostalCode", order.ShipPostalCode);
AddParameter(command, "@ShipCountry", order.ShipCountry);
_context.Database.OpenConnection();

using var dataReader = command.ExecuteReader();
dataReader.Read();
order.OrderId = Convert.ToInt32(dataReader[0]);
}

using (var command = _context.Database.GetDbConnection().CreateCommand())
{
var values = new List<string>();
foreach (var (orderDetails, i) in order.OrderDetails.WithIndex())
{
orderDetails.OrderId = order.OrderId;
values.Add($"(@OrderId{i}, @ProductId{i}, @UnitPrice{i}, @Quantity{i}, @Discount{i})");
AddParameter(command, $"@OrderId{i}", orderDetails.OrderId);
AddParameter(command, $"@ProductId{i}", orderDetails.ProductId);
AddParameter(command, $"@UnitPrice{i}", orderDetails.UnitPrice);
AddParameter(command, $"@Quantity{i}", orderDetails.Quantity);
AddParameter(command, $"@Discount{i}", orderDetails.Discount);
}

command.CommandText = "INSERT INTO OrderDetails " +
"(OrderId, ProductId, UnitPrice, Quantity, Discount) VALUES " +
string.Join(",", values);

if (order.Shipment != null)
{
var shipment = order.Shipment;
shipment.OrderId = order.OrderId;
command.CommandText += ";\nINSERT INTO Shipments " +
"(OrderId, ShipperId, ShipmentDate, TrackingNumber) VALUES " +
"(@ShipmentOrderId, @ShipperId, @ShipmentDate, @TrackingNumber)";
AddParameter(command, "@ShipmentOrderId", shipment.OrderId);
AddParameter(command, "@ShipperId", shipment.ShipperId);
AddParameter(command, "@ShipmentDate", shipment.ShipmentDate);
AddParameter(command, "@TrackingNumber", shipment.TrackingNumber);
}

_context.Database.OpenConnection();
command.ExecuteNonQuery();
}

return order.OrderId;
}

private static void AddParameter(System.Data.Common.DbCommand command, string name, object? value)
{
var parameter = command.CreateParameter();
parameter.ParameterName = name;
parameter.Value = value ?? DBNull.Value;
command.Parameters.Add(parameter);
}

public void CreateOrderPayment(int orderId, decimal amountPaid, string creditCardNumber, DateTime expirationDate, string approvalCode)
{
var orderPayment = new OrderPayment()
Expand Down
Loading