Skip to content

[probe — do not merge] semver gate (base-commit baseline) must fail without the breaking label - #29

Closed
dsociative wants to merge 1 commit into
feat/26-non-exhaustive-modelsfrom
probe/semver-red-path-2
Closed

[probe — do not merge] semver gate (base-commit baseline) must fail without the breaking label#29
dsociative wants to merge 1 commit into
feat/26-non-exhaustive-modelsfrom
probe/semver-red-path-2

Conversation

@dsociative

Copy link
Copy Markdown
Owner

Throwaway PR: removes UserRole.id without the breaking label. Expected: the semver job fails against the PR's base commit. Will be closed once observed.

@dsociative

Copy link
Copy Markdown
Owner Author

Observed with the base-commit baseline: semver fails on a breaking change without the breaking label (struct_pub_field_missing), while #27 with the label passes. Probe done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant