Skip to content

[probe — do not merge] semver gate must fail on a breaking change without the breaking label - #28

Closed
dsociative wants to merge 1 commit into
feat/26-non-exhaustive-modelsfrom
probe/semver-red-path
Closed

[probe — do not merge] semver gate must fail on a breaking change without the breaking label#28
dsociative wants to merge 1 commit into
feat/26-non-exhaustive-modelsfrom
probe/semver-red-path

Conversation

@dsociative

Copy link
Copy Markdown
Owner

Throwaway PR: removes UserRole.id (a breaking change) without the breaking label. Expected: the semver job fails. Will be closed once observed.

@dsociative

Copy link
Copy Markdown
Owner Author

Observed: the semver job fails on a breaking change without the breaking label (struct_pub_field_missing on UserRole.id), while #27 with the label passes. Probe done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant