test: refresh card fixtures from live captures; fix(cli): empty Properties block for {} - #25
Merged
Merged
Conversation
Kaiten returns `"properties": {}` for a card without custom properties; `card
view` printed an empty `Properties:` block with `{}` under it. The hand-made
fixture said `null`, which hid this — found while refreshing the fixtures from
live captures. The MCP projection already treated an empty object as "none".
…itized) The card fixtures were hand-trimmed subsets of July captures (9–39 of the 90 keys a card carries, `external_links` absent everywhere), later enriched by hand with a child card, a file and a blocker that no longer existed on the test account. They are now full captures of the frozen dstest fixture card 67089469 and of `GET /cards?space_id=810671`, sanitized (emails → `<user>@example.com`, avatar data URLs → null, inbound email keys zeroed, share ids null). Hand overlays remain only for what the test tariff cannot produce — relations (`children`), blocking (`blockers`, `blocked`) and custom `properties` — plus the CLI's two-item checklist and two-tag scenarios. Test constants follow the permanent attachment (file 62769658), the list has the five real cards (one title with an emoji and Cyrillic), and one wrong assumption is corrected: list cards do carry members, tags and checklists.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 86.69% 86.70%
=======================================
Files 33 33
Lines 4894 4897 +3
=======================================
+ Hits 4243 4246 +3
Misses 651 651 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…e card); review follow-ups The two-item checklist scenario is captured live again: the frozen dstest fixture card got a permanent unchecked "second item", so the checklist and `goals_*` counters come from the API as they are. `card_with_tags.json` keeps its legacy tag-without-tag_id overlay with a consistent `tag_ids`. The "no properties" predicate is shared by the CLI and the MCP projection (`properties::no_properties`); README example uses the permanent attachment id.
dsociative
force-pushed
the
chore/refresh-card-fixtures
branch
from
August 27, 2026 15:40
46e73e8 to
27a562f
Compare
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The card fixtures were hand-trimmed subsets of July captures (9–39 of the ~90 keys a card carries;
external_linksabsent everywhere) and had been enriched by hand with a child card, a file and a blocker that no longer existed on the test account. Tests could only prove that the models parse what we thought the API returns.What
card_get_full.json(both crates),mcp_card_full.json,card_get_no_properties.json,card_with_tags.json,card_with_checklists.json,cards_list.json(both crates) are now full live captures of the dstest fixture card 67089469 (GET /cards/{id}) and ofGET /cards?space_id=810671, sanitized: emails →<user>@example.com, avatar data URLs →null, inbound email keys zeroed, share idsnull.children), blocking (blockers/blocked) and customproperties— plus the CLI two-item checklist and two-tag scenarios.probe-attach.txt= file 62769658, permanent external link); a separate card is the playground for mutating smoke tests.members,tagsandchecklists(the old test asserted they don't).Bug found by the realistic fixtures
Kaiten returns
"properties": {}for a card without custom properties;card viewprinted an emptyProperties:block with{}under it (reproduced live on dstest). The hand-made fixture saidnulland hid it. Fixed in the first commit (fix(cli): …), verified RED → GREEN in isolation; the MCP projection already treated{}as "none".No public API change; fix → 0.5.1.