feat: upgrade to jsonc-parser 0.34 for JSON5 support - #16
Merged
Merged
Conversation
Exposes the new allowBareDecimalPointNumbers, allowNonFiniteNumbers and allowExtendedStringEscapes options (off in parseStrict/parseToValueStrict), and newlineKind() can now return "\r" since a lone carriage return ends a line comment. Also removes the README's sorting section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades to jsonc-parser 0.34.0, which adds JSON5 support.
ParseOptions:allowBareDecimalPointNumbers(.5,5.),allowNonFiniteNumbers(Infinity,-Infinity,NaN) andallowExtendedStringEscapes(\x41,\v,\0, line continuations). They default totrueforparse/parseToValueand tofalseforparseStrict/parseToValueStrict.true,null) or contain$.\rnow ends a line comment, sonewlineKind()can return"\r". The TypeScript return type is updated to match.Known limitations, both from jsonc-parser's serde_json conversion:
parseToValuethrows onInfinity/NaNeven whenallowNonFiniteNumbersis on, because serde_json can't represent them. This is now noted in the option's doc comment.toValue()on a CST node holdingInfinity/NaNreturns the string (e.g."NaN"), not a number.