Repository navigation
fix(api): map workspace package paths to source in api tsconfig (#956) - #1016
Open
Ranjeet2063 wants to merge 2 commits into
Open
Ranjeet2063 wants to merge 2 commits into
Ranjeet2063 wants to merge 2 commits into
Conversation
…ocs#956) Decouple @vercel/node function type-check from emitted declarations by pointing tsconfig paths directly to live workspace source modules. This prevents TS2305 missing export errors when Vercel restores stale package dist cache across consecutive deployments. Closes drydocs#956
|
@Ranjeet2063 is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #956
Summary of Changes
Decouples Vercel's serverless function type-checking () from emitted declaration files by adding explicit path mappings in directly to the live workspace package sources.
Background & Root Cause
Production Vercel deployments were failing in the serverless function type-check phase with errors such as:
While CI passes cleanly, Vercel restores
packages/*/distfrom previous deployment caches. If@vercel/noderuns its independenttscoverapi/**against stale.d.tsdeclarations, newly introduced exports fail to resolve.Implementation Details
pathsinapi/tsconfig.json:@meridian/shared->["../packages/shared/src/index.ts"]: Points directly to shared schemas and constants.@meridian/api-core->["../packages/api-core/src/index.ts"]: Points to core API handlers.@meridian/stellar-sdk-helpers->["../packages/stellar-sdk-helpers/src/index.ts"]: Points to keeper, rate source, and sdk helper sources.dist/index.jsvia each package'smain.Local Verification
packages/shared/dist,packages/api-core/dist, andpackages/stellar-sdk-helpers/dist.pnpm typecheck:api-> Passed with 0 errors, confirming that typechecking no longer depends on emitted declarations.pnpm build: 10/10 tasks successful (wasm contracts, sdk, web, apps).pnpm typecheck: 12/12 packages passed cleanly.pnpm typecheck:api: Passed cleanly.pnpm lint: All packages passed without lint warnings.pnpm test: 40 test files passed (335/335 unit tests passing).