Repository navigation
Reduce spinner flickering - #182
Merged
Merged
Conversation
Instead of clearing the line and rewriting from the beginning (which can lead to flickering for terminals that refresh very quickly, because they show the line in its temporarily blank state), draw _over_ the previous frame and then clear any remining characters to the right hand side.
alassek
approved these changes
Nov 6, 2026
alassek
left a comment
alassek
left a comment
Contributor
There was a problem hiding this comment.
High-speed terminals change the conventional wisdom 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of clearing the line and rewriting from the beginning (which can lead to flickering for terminals that refresh very quickly, because they show the line in its temporarily blank state), draw over the previous frame and then clear any remaining characters to the right hand side.
I tested this with hanami-cli main and the spinner states under the "Installing" step look a whole lot better now (Ghostty on macOS), whereas previously they were flickering.