Repository navigation
Add Dry::CLI.accepted_kwargs public method - #181
Merged
Merged
Conversation
This makes public the API that we’re using in Hanami CLI to wrap command `#call` methods and ensure we pass along only their accepted kwargs. As part of this, be more precise when we talk about “args” (or “kwargs”) vs “params”. Args are the explicit values we pass to a method; params are the declarad parameters on the method itself, nothing more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes public the API that we’re using in Hanami CLI to wrap command
#callmethods and ensure we pass along only their accepted kwargs.As part of this, be more precise when we talk about “args” (or “kwargs”) vs “params”. Args are the actual values we pass when calling a method; params are the declared parameters on the method itself, nothing more.