Repository navigation
Fix overridden method of Some returning Any - #2559
Merged
Merged
Conversation
jorenham
force-pushed
the
typing/fix-maybe
branch
from
October 26, 2026 16:28
d7af6a5 to
2789d09
Compare
Contributor
sobolevn
approved these changes
Oct 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 80 82 +2
Lines 2485 2693 +208
Branches 437 45 -392
==========================================
+ Hits 2485 2693 +208 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have
madefixedindented things!Several overridden methods in
maybe.Some(andmaybe._Nothing) were outside theif not TYPE_CHECKINGblock. But because they're unannotated, mypy inferred their return types asAny. This fixes it by me theatrically pressing tab on the selection of these methods (plus a-> Neverand anotherif not TYPE_CHECKINGblock).Checklist
CHANGELOG.mdRelated issues
I checked, but found no related issues.
🙏 Please, if you or your company finds
dry-pythonvaluable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.