Skip to content

BDX-1369: Send queries list in catalog search requests - #38

Open
leewjae wants to merge 3 commits into
dremio:mainfrom
leewjae:BDX-1369-search-queries
Open

leewjae wants to merge 3 commits into
dremio:mainfrom
leewjae:BDX-1369-search-queries

Conversation

@leewjae

@leewjae leewjae commented Oct 6, 2026 •

Copy link
Copy Markdown

Ticket: BDX-1369

Why

dremio/dremio#29340 (master) and dremio/dremio#29474 (sap-fork) changed the search request (POST /v0/projects/{pid}/search, /api/v3/search) to require queries: list[str]. The scalar query field is no longer read, so dremio search fails against new backends.

What changed

  • DremioClient.search() takes queries: list[str] and sends only "queries"; the legacy "query" field is no longer sent.
  • The search command accepts one or more terms (drs search "revenue" "sales"); multiple terms are searched as alternatives. A single term works as before. README and command introspection updated.
  • Tests assert the full request body for one term, multiple terms, and the empty-term ([""] = match-all) case, plus a CLI-level multi-term test.

Compatibility

Requires a Dremio version with the queries contract. Older versions read only query and will reject these requests.

Validation

  • uv run ruff check .: passed
  • uv run ruff format --check .: passed
  • uv run pytest tests/: 235 passed

Not tested against a live Dremio backend.

🤖 Generated with Claude Code

leewjae and others added 2 commits October 6, 2026 13:29
Newer Dremio search endpoints require the queries list and no longer read
the scalar query field. Send both so the CLI works against old and new
backends.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dremio search now accepts one or more terms, sent as the queries list.
The legacy query field carries the first non-blank term for older
backends. The max term count is enforced by the backend.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CLAassistant

CLAassistant commented Oct 6, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants