fix: list the remaining files when there are more than GitHub's annotation limit - #32
Merged
Conversation
dsherret
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub shows at most 10 error annotations per step and silently ignores the rest, so when more than 10 files weren't formatted, the eleventh file onward didn't appear anywhere on the pull request.
Now when there are more than 10 files, the first 9 get their usual annotation and the tenth lists the remaining files:
Exactly 10 files still annotates every file. The list is capped at the same 4000 characters as the diff, with a note pointing at the log.