ci: exclude parser-stack bumps from Dependabot auto-merge#40
Merged
Conversation
The tree-sitter CLI regenerates parser.c and the language shim is linked into every binding, so both change parse behavior, and no CI job here exercises the committed parser against a freshly generated one. Excluded by dependency name rather than by semver range: these are 0.x packages where a minor bump is a breaking change in practice. dependabot.yml already holds tree-sitter-cli minors; this covers its patches too, and covers the shim. Holding such a bump by intention alone does not work. A Dependabot PR blocked only by a merge conflict auto-merges the moment the conflict clears, regardless of any intent to review it first.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tree-sitterCLI regeneratesparser.candtree-sitter-languageis linked into every binding, so both change parse behavior — and no CI job here exercises the committed parser against a freshly generated one.Excluded by dependency name rather than by semver range, because these are 0.x packages where a minor bump is a breaking change in practice.
dependabot.ymlalready ignorestree-sitter-climinors, with the reasoning that a bad 0.x bump would auto-merge silently and only surface at the next localtree-sitter generate. That reasoning applies equally to its patches and totree-sitter-language, so this extends the same hold to both, in the place that governs merging rather than the place that governs opening.Holding such a bump by intention alone does not work: a Dependabot PR blocked only by a merge conflict auto-merges the moment that conflict clears. The companion change in the LSP repository has the same shape, prompted by a runtime bump there that merged itself three minutes after an unrelated PR unblocked it.
Auto-merge remains enabled for everything else, including CI actions and dev tooling.