Repository navigation
chore: 🐛 rename to file_path so write() doesn't create dir of file name - #140
Merged
lwjohnst86 merged 1 commit intoOct 29, 2026
Merged
Conversation
…ir with intended file name When renaming the the input and variable name in #134, I accidentelly changed it so we call `.mkdir()` on the intended file name.
signekb
marked this pull request as ready for review
October 29, 2026 15:28
lwjohnst86
changed the title
file_path so write() doesn't create dir with intended file namefile_path so write() doesn't create dir of file name
lwjohnst86
approved these changes
Oct 29, 2026
github-project-automation
Bot
moved this from In review
to Approved
in Platform development
lwjohnst86
deleted the
chore/fix-rename-var-to-file_path-in-data-write-function
branch
October 29, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When renaming the input and variable name in #134, I accidentally changed it so we call
.mkdir()on the intended file name. This fixes that and change the variable name tofile_pathso it's clearer.Needs a quick review.