Repository navigation
Fix high-priority chat, persistence, AI worker and chart reliability issues - #12
Merged
Merged
Conversation
dovvnloading
commented
Nov 8, 2026
dovvnloading
left a comment
Owner
Author
There was a problem hiding this comment.
Review completed on head 45babfa5381546d82c04d49194c18e4197666c35. I checked the changed chat/error-recovery, persistence, regeneration lifecycle, provider timeout, chart bounds, and regression-test paths. During review I caught and corrected two additional issues: the background regeneration callback could outlive its temporary context menu; a failed AI response node could leave chat input disabled. Both now have regression coverage. CI for this head passes all 21 tests. No further blocking issues found in the reviewed diff. Follow-up: manual Qt desktop smoke testing and moving synchronous API-model discovery off the UI thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the P1 problems identified in the November 8 Graphite code review without changing
maindirectly.[h...]message text and recover controls if node creation fails.Tests
Added
tests/test_high_priority_fixes.pywith regression coverage for literal header text, UI recovery, branch-preserving regeneration, unsaved editing, active chat deletion, provider timeout use, and chart validation.Run:
Follow-up