Conversation
Add the Microsoft.Extensions.Configuration.EnvironmentVariables 10.0.0 reference package required by OpenTelemetry 1.18.0 and refresh the external component metadata and patches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2058f6bb-3bc5-4873-af70-0538db686ef1
| <OpenTelemetryDotNetContribHttpReleaseVersion>1.16.0</OpenTelemetryDotNetContribHttpReleaseVersion> | ||
| <OpenTelemetryDotNetContribRuntimeReleaseVersion>1.15.1</OpenTelemetryDotNetContribRuntimeReleaseVersion> | ||
| <OpenTelemetryDotNetContribPersistentStorageAbstractionsReleaseVersion>1.1.0</OpenTelemetryDotNetContribPersistentStorageAbstractionsReleaseVersion> | ||
| <OpenTelemetryDotNetContribPersistentStorageFileSystemReleaseVersion>1.1.0</OpenTelemetryDotNetContribPersistentStorageFileSystemReleaseVersion> |
There was a problem hiding this comment.
| <OpenTelemetryDotNetContribPersistentStorageFileSystemReleaseVersion>1.1.1</OpenTelemetryDotNetContribPersistentStorageFileSystemReleaseVersion> |
There was a problem hiding this comment.
Should we also update the persistent file store version ? It's updated in the PR. https://github.com/dotnet/sdk/pull/56274/changes#diff-1ea18ff65faa2ae6fed570b83747086d0317f5e4bc325064f6c14319a9c4ff67 and https://github.com/dotnet/source-build-assets/pull/1742/changes
I'm also surprised <AzureMonitorOpenTelemetryExporterPackageVersion>1.9.0</AzureMonitorOpenTelemetryExporterPackageVersion> is not needed but I don't see the prior exporter package version defined here either.
There was a problem hiding this comment.
Checking on this as I'm not familiar with how this works.
There was a problem hiding this comment.
Looks like bumping this is maybe not required but good for hygiene. The pdb issue appears to need resolution though. I'm not sure why but it looks like the azure-monitor-exporter is not a requirement for source-build to build.
There was a problem hiding this comment.
So it looks like the build failed in the previous bump PR as well but the build is deleted so I can't tell why.
There was a problem hiding this comment.
I think the base needs to be made off release/11.0.1xx so putting up another PR.
|
source-build-assets-unified-build is failing because there's a mismatch between the SDK's referenced OTel version (1.16.0) and the updated version here (1.18.0). Also, this is targeting main which is going to have no impact on dotnet/dotnet#9622 since that targets 11.0-rc.2. |
|
Thanks @JoeRobich for moving this along while I was conducting interviews and @mthalman for helping to push this along in the 11.0 version - #1803. |
3 participants
Summary
This addresses the missing prebuilts reported in this dotnet/dotnet#9622 comment.
Validation
./build.sh --clean && ./build.sh -sb