Improve Native AOT command migration skill - #55843
Merged
JeremyKuhne merged 2 commits intoAug 18, 2026
Merged
Conversation
JeremyKuhne
requested review from
a team,
lbussell and
mthalman
as code owners
August 18, 2026 18:22
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates repository guidance for migrating or reviewing dotnet CLI commands in the Native AOT CLI (src/Cli/dotnet-aot) by expanding the add-dotnet-aot-command skill into a more complete author + reviewer workflow, and clarifying closure ownership boundaries between AotSourceFiles.props and AotDependencies.props.
Changes:
- Expanded
.github/skills/add-dotnet-aot-command/SKILL.mdinto a structured workflow (contracts, author/reviewer checklists, validation ladder, and evidence expectations). - Clarified that
AotSourceFiles.propsowns linked sources/resources, while package/project dependency closure belongs inAotDependencies.props. - Added more explicit validation/evidence guidance (clean builds after closure changes, Native AOT publish, native test runs,
dnparity, separated layout, and size reporting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet-aot/AotSourceFiles.props | Updates the header guidance to direct dependency additions to AotDependencies.props, reinforcing the intended closure split. |
| .github/skills/add-dotnet-aot-command/SKILL.md | Rewrites and expands the skill into a self-contained migration/review workflow with contracts, validation ladder, and evidence requirements. |
mthalman
reviewed
Aug 18, 2026
mthalman
approved these changes
Aug 18, 2026
JeremyKuhne
enabled auto-merge (squash)
August 18, 2026 20:34
JeremyKuhne
had a problem deploying
to
copilot-pat-pool
August 18, 2026 21:11 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnparity, separated layouts, and size evidenceAotSourceFiles.propsowns source and resources whileAotDependencies.propsowns package and project dependenciesValidation
./.dotnet/dotnet.exe .github/skills/ValidateSkill.cs .github/skills/add-dotnet-aot-commandgit diff --checkNo product tests were run because this changes agent guidance and an MSBuild comment only.