Skip to content

Reenable artifacts cleanup test - #55835

Open
marcpopMSFT wants to merge 1 commit into
mainfrom
marcpopmsft-weekly-test-cleanup
Open

Reenable artifacts cleanup test#55835
marcpopMSFT wants to merge 1 commit into
mainfrom
marcpopmsft-weekly-test-cleanup

Conversation

@marcpopMSFT

Copy link
Copy Markdown
Member

Summary

  • reenable PublishingRegistersWrittenFilesForProperCleanup
  • restore coverage that verifies a framework-dependent build removes stale self-contained publish artifacts
  • follow up on the MSBuild cleanup support restored by Redo filewritessharable change  msbuild#12554

This is part of the weekly test issue cleanup effort to burn down the SDK's Test Debt and Known Build Error issues.

Closes #50140

Validation

  • Microsoft.NET.Build.Tests.ArtifactsOutputPathTests.PublishingRegistersWrittenFilesForProperCleanup

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 17:18
@marcpopMSFT
marcpopMSFT requested a review from a team as a code owner August 18, 2026 17:18
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables the PublishingRegistersWrittenFilesForProperCleanup test in dotnet/sdk now that the underlying MSBuild cleanup behavior has been restored (follow-up to dotnet/msbuild#12554), closing #50140. The goal is to restore coverage ensuring stale self-contained publish artifacts (e.g., hostfxr) are properly removed when transitioning to a framework-dependent build.

Changes:

  • Removed the [Ignore] attribute from PublishingRegistersWrittenFilesForProperCleanup so it runs again in CI.
  • Restored test coverage for verifying stale self-contained publish outputs are cleaned up for framework-dependent builds.

@marcpopMSFT
marcpopMSFT requested a review from joeloff August 18, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reenable PublishingRegistersWrittenFilesForProperCleanup test once msbuild changes are unreverted again

3 participants