Skip to content

Recognize roslyn telemetry - #55572

Merged
baronfel merged 4 commits into
dotnet:mainfrom
jjonescz:roslyn-telemetry
Aug 17, 2026
Merged

Recognize roslyn telemetry#55572
baronfel merged 4 commits into
dotnet:mainfrom
jjonescz:roslyn-telemetry

Conversation

@jjonescz

@jjonescz jjonescz commented Aug 3, 2026

Copy link
Copy Markdown
Member

Roslyn counterpart: dotnet/roslyn#84725
Docs counterpart: dotnet/docs#55359

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

This PR has been labeled with Area-Telemetry. Please ensure that any telemetry changes in this PR

@jjonescz
jjonescz marked this pull request as ready for review August 3, 2026 13:44
@jjonescz
jjonescz requested a review from a team as a code owner August 3, 2026 13:44
Copilot AI review requested due to automatic review settings August 3, 2026 13:44
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds recognition/forwarding of the new Roslyn compiler cache telemetry event from MSBuild into the dotnet CLI telemetry pipeline, aligning with the Roslyn-side telemetry emission.

Changes:

  • Allowlist and forward the roslyn/compilercache MSBuild telemetry event via MSBuildLogger.FormatAndSend.
  • Add a dotnet.Tests regression test verifying the event is forwarded with the expected msbuild/ prefix and properties.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/dotnet.Tests/CommandTests/MSBuild/GivenMSBuildLogger.cs Adds a test ensuring the Roslyn compiler cache telemetry event is forwarded.
src/Cli/dotnet/Commands/MSBuild/MSBuildLogger.cs Adds the Roslyn compiler cache telemetry event name and forwards it via the MSBuild telemetry allowlist.

@jjonescz

Copy link
Copy Markdown
Member Author

@baronfel @dsplaisted for a review, thanks

@baronfel
baronfel merged commit af6ecc2 into dotnet:main Aug 17, 2026
22 checks passed
@baronfel

Copy link
Copy Markdown
Member

@jjonescz I'm not sure if this will auto-flow to RC1 or not - may want to backport just to be safe.

@jjonescz
jjonescz deleted the roslyn-telemetry branch August 17, 2026 17:44
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 18, 2026
@jjonescz

Copy link
Copy Markdown
Member Author

/backport to release/11.0.1xx-rc1

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx-rc1 (link to workflow run)

@jjonescz

Copy link
Copy Markdown
Member Author

/backport to release/11.0.1xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants