Skip to content

Avoid the intermediate array allocation in project OtherOptions #20499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xperiandri wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −8
Open

Avoid the intermediate array allocation in project OtherOptions #20499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04a451f
Avoid the intermediate array allocation in project OtherOptions
xperiandri Sep 9, 2026
bddd2eb
Add the release note link for PR #20499
xperiandri Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.VisualStudio/18.vNext.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* Fix doubled F# diagnostics in tooltips. ([Issue #16360](https://github.com/dotnet/fsharp/issues/16360))
* Fix `NotSupportedException` in the memory-mapped-file optimization when copying `ReadOnlyMemory` into `MemoryMappedFileViewStream`. ([Issue #20263](https://github.com/dotnet/fsharp/issues/20263))
* Reduce allocations in the VS project options reactor: the command-line options and project options caches and the mailbox reply payloads now hold struct tuples, and `IProjectSite.CompilationBinOutputPath` returns `string voption` picked with a new `Array.tryPickV`. ([PR #20413](https://github.com/dotnet/fsharp/pull/20413))
* Build a single-file project's `OtherOptions` reference flags with one array comprehension instead of two `Array.ofSeq` calls and an `Array.append`. ([PR #20499](https://github.com/dotnet/fsharp/pull/20499))

### Changed

Expand Down
14 changes: 6 additions & 8 deletions vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,14 +238,12 @@ type private FSharpProjectOptionsReactor(checker: FSharpChecker) =

let otherOptions =
if project.IsFSharpMetadata then
project.ProjectReferences
|> Seq.map (fun x -> "-r:" + project.Solution.GetProject(x.ProjectId).OutputFilePath)
|> Array.ofSeq
|> Array.append (
project.MetadataReferences.OfType<PortableExecutableReference>()
|> Seq.map (fun x -> "-r:" + x.FilePath)
|> Array.ofSeq
)
[|
for x in project.MetadataReferences.OfType<PortableExecutableReference>() do
yield "-r:" + x.FilePath
for x in project.ProjectReferences do
yield "-r:" + project.Solution.GetProject(x.ProjectId).OutputFilePath
|]
else
[||]

Expand Down
Loading