Typed tree: create a type's augmentation on first use - #20494
Open
auduchinok wants to merge 2 commits into
Open
Conversation
An entity now starts with no TyconAugmentation and materialises one atomically on the first TypeContents access, so entities that never gain members hold none. The closed flag moves into EntityFlags, where it is readable without forcing an augmentation into existence, and remapping preserves an absent one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
⚠️ Affects-Compiler-Output
Contributor
|
🔍 Tooling Safety Check — Affects-Bootstrap, Affects-Compiler-Output
|
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
self-requested a review
September 9, 2026 09:47
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Entityallocated aTyconAugmentationrecord at construction. An imported IL type never writes toit:
NewILTyconsets exactly one field,tcaug_closed <- true, and most imported types are never askedfor their contents at all.