-
Notifications
You must be signed in to change notification settings - Fork 875
Let FSharpProjectSnapshot.FromOptions take reference stamps from the host
#20459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xperiandri
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
xperiandri:perf/snapshot-reference-stamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
155 changes: 56 additions & 99 deletions
155
tests/FSharp.Compiler.ComponentTests/FSharpChecker/ProjectSnapshot.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,104 +1,61 @@ | ||
| module FSharpChecker.ProjectSnapshot | ||
|
|
||
| open Xunit | ||
| open System | ||
| open System.IO | ||
| open System.Threading.Tasks | ||
| open FSharp.Compiler.CodeAnalysis | ||
| open FSharp.Compiler.CodeAnalysis.ProjectSnapshot | ||
| open Xunit | ||
|
|
||
|
|
||
| // TODO: restore tests | ||
|
|
||
| //[<Fact>] | ||
| //let WithoutImplFilesThatHaveSignatures () = | ||
|
|
||
| // let snapshot = FSharpProjectSnapshot.Create( | ||
| // projectFileName = "Dummy.fsproj", | ||
| // projectId = None, | ||
| // sourceFiles = [ | ||
| // { FileName = "A.fsi"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "A.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "B.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "C.fsi"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "C.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // ], | ||
| // referencesOnDisk = [], | ||
| // otherOptions = [], | ||
| // referencedProjects = [], | ||
| // isIncompleteTypeCheckEnvironment = true, | ||
| // useScriptResolutionRules = false, | ||
| // loadTime = DateTime(1234, 5, 6), | ||
| // unresolvedReferences = None, | ||
| // originalLoadReferences = [], | ||
| // stamp = None | ||
| // ) | ||
|
|
||
| // let result = snapshot.WithoutImplFilesThatHaveSignatures | ||
|
|
||
| // let expected = [| "A.fsi"; "B.fs"; "C.fsi" |] | ||
|
|
||
| // Assert.Equal<string array>(expected, result.SourceFileNames |> List.toArray) | ||
|
|
||
| // Assert.Equal<byte array>(result.FullVersion, snapshot.SignatureVersion) | ||
|
|
||
| //[<Fact>] | ||
| //let WithoutImplFilesThatHaveSignaturesExceptLastOne () = | ||
|
|
||
| // let snapshot = FSharpProjectSnapshot.Create( | ||
| // projectFileName = "Dummy.fsproj", | ||
| // projectId = None, | ||
| // sourceFiles = [ | ||
| // { FileName = "A.fsi"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "A.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "B.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "C.fsi"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "C.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // ], | ||
| // referencesOnDisk = [], | ||
| // otherOptions = [], | ||
| // referencedProjects = [], | ||
| // isIncompleteTypeCheckEnvironment = true, | ||
| // useScriptResolutionRules = false, | ||
| // loadTime = DateTime(1234, 5, 6), | ||
| // unresolvedReferences = None, | ||
| // originalLoadReferences = [], | ||
| // stamp = None | ||
| // ) | ||
|
|
||
| // let result = snapshot.WithoutImplFilesThatHaveSignaturesExceptLastOne | ||
|
|
||
| // let expected = [| "A.fsi"; "B.fs"; "C.fsi"; "C.fs" |] | ||
|
|
||
| // Assert.Equal<string array>(expected, result.SourceFileNames |> List.toArray) | ||
|
|
||
| // Assert.Equal<byte array>(result.FullVersion, snapshot.LastFileVersion) | ||
|
|
||
|
|
||
| //[<Fact>] | ||
| //let WithoutImplFilesThatHaveSignaturesExceptLastOne_2 () = | ||
|
|
||
| // let snapshot = FSharpProjectSnapshot.Create( | ||
| // projectFileName = "Dummy.fsproj", | ||
| // projectId = None, | ||
| // sourceFiles = [ | ||
| // { FileName = "A.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "B.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // { FileName = "C.fs"; Version = "1"; GetSource = Unchecked.defaultof<_> } | ||
| // ], | ||
| // referencesOnDisk = [], | ||
| // otherOptions = [], | ||
| // referencedProjects = [], | ||
| // isIncompleteTypeCheckEnvironment = true, | ||
| // useScriptResolutionRules = false, | ||
| // loadTime = DateTime(1234, 5, 6), | ||
| // unresolvedReferences = None, | ||
| // originalLoadReferences = [], | ||
| // stamp = None | ||
| // ) | ||
|
|
||
| // let result = snapshot.WithoutImplFilesThatHaveSignaturesExceptLastOne | ||
|
|
||
| // let expected = [| "A.fs"; "B.fs"; "C.fs" |] | ||
|
|
||
| // Assert.Equal<string array>(expected, result.SourceFileNames |> List.toArray) | ||
|
|
||
| // Assert.Equal<byte array>(result.FullVersion, snapshot.LastFileVersion) | ||
|
|
||
| #nowarn "57" | ||
|
|
||
| let private projectOptions projectFileName references referencedProjects = | ||
| { | ||
| ProjectFileName = projectFileName | ||
| ProjectId = None | ||
| SourceFiles = [| Path.ChangeExtension(projectFileName, ".fs") |] | ||
| OtherOptions = [| for path in references -> $"-r:{path}" |] | ||
| ReferencedProjects = referencedProjects | ||
| IsIncompleteTypeCheckEnvironment = false | ||
| UseScriptResolutionRules = false | ||
| LoadTime = DateTime.UtcNow | ||
| UnresolvedReferences = None | ||
| OriginalLoadReferences = [] | ||
| Stamp = None | ||
| } | ||
|
|
||
| let private emptySource _ path = | ||
| async { return FSharpFileSnapshot.CreateFromString(path, "") } | ||
|
|
||
| [<Fact>] | ||
| let ``FromOptions takes reference stamps from the host, including referenced projects`` () : Task = | ||
| task { | ||
| let stamps = | ||
| dict | ||
| [ | ||
| "MainRef.dll", DateTime(2026, 1, 1, 0, 0, 0, DateTimeKind.Utc) | ||
| "LibRef.dll", DateTime(2026, 2, 2, 0, 0, 0, DateTimeKind.Utc) | ||
| ] | ||
|
|
||
| let lib = projectOptions "Lib.fsproj" [ "LibRef.dll" ] [||] | ||
|
|
||
| let main = | ||
| projectOptions "Main.fsproj" [ "MainRef.dll" ] [| FSharpReferencedProject.FSharpReference("Lib.dll", lib) |] | ||
|
|
||
| let! snapshot = FSharpProjectSnapshot.FromOptions(main, emptySource, getReferenceStamp = (fun path -> stamps[path])) | ||
|
|
||
| let libSnapshot = | ||
| match snapshot.ReferencedProjects with | ||
| | [ FSharpReferencedProjectSnapshot.FSharpReference(_, lib) ] -> lib | ||
| | other -> failwith $"Expected one referenced project, got %A{other}" | ||
|
|
||
| Assert.Equal<ReferenceOnDisk list>( | ||
| [ { Path = "MainRef.dll"; LastModified = stamps["MainRef.dll"] } ], | ||
| snapshot.ReferencesOnDisk | ||
| ) | ||
|
|
||
| Assert.Equal<ReferenceOnDisk list>( | ||
| [ { Path = "LibRef.dll"; LastModified = stamps["LibRef.dll"] } ], | ||
| libSnapshot.ReferencesOnDisk | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖🕵️ Keep the existing public
FromOptionsCLR method. Put shared logic in a private implementation and expose a distinctly named internal host entry point for the editor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xperiandri but arguments are optional