Fix infinite loop in Repl#5882
Merged
Merged
Conversation
3aee960 to
fdff67c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an infinite loop in the REPL’s redirected-input mode by distinguishing EOF (Console.ReadLine() returning null) from an empty line (""). This addresses scenarios where the parent process closes stdin (e.g., when a driving process/LLM closes the pipe), causing ReadLine() to repeatedly return null.
Changes:
- Add an explicit
line == null(EOF) check when input is redirected, and exit the input loop. - Replace
string.IsNullOrEmpty(line)with separate handling for EOF vs empty string.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Diagnostics.Repl/ConsoleService.cs | Prevents an infinite loop on redirected stdin EOF by breaking out of the REPL read loop. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
steveisok
approved these changes
Jun 16, 2026
hoyosjs
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using ReadLine + IsNullOrEmpty + continue:
Produces an infinite loop if stdin was closed. For example, running under an llm and it closes the pipe to the tool.