Repository navigation
Fix permissions for path-addressed drive items - #1919
Merged
waldekmastykarz merged 1 commit intoOct 10, 2026
Merged
Conversation
Canonicalize Graph drive item paths to their equivalent ID-addressed routes before querying the permissions service. Closes dotnet#1918. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8a9b0692-9775-4433-b9b0-b65f1d6ff25c
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated requirements and includes comprehensive coverage of the affected URL forms.
0 open findings
What changed in this PR
Canonicalizes path-addressed Microsoft Graph drive-item URLs before permission lookup.
Changes:
- Converts root-, item-, and special-folder paths to ID-addressed routes.
- Supports direct and batch requests with operation suffixes and special characters.
- Adds focused integration tests.
| File | Description |
|---|---|
DevProxy.Plugins/Utils/GraphUtils.cs |
Adds drive-item path canonicalization. |
DevProxy.Integration.Tests/GraphUtilsTests.cs |
Tests supported routes and batch handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/drivealias to/me/driveand preserve operation suffixesWhy
The permissions service resolves ID-addressed drive item routes reliably, while concrete
root:/path:/...routes and Dev Proxy's previousroot:<value>/...form fail. Canonicalizing at the permissions boundary avoids changing the shared URL sanitizer and also handles other path-addressed drive item APIs beyond the upload reported in #1918.Tests
dotnet test DevProxy.Integration.Tests/DevProxy.Integration.Tests.csproj --filter FullyQualifiedName~GraphUtilsTests --no-restore --verbosity minimal --maxcpucount:1 -p:RunPostBuildEvent=Never -p:UseSharedCompilation=falseCloses #1918