Skip to content

Update comments in /refresh implementation #69506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Youssef1313 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update comments in /refresh implementation #69506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1836f51
Update comments in `/refresh` implementation
Youssef1313 Sep 25, 2026
5d14646
Apply Copilot suggestion
Youssef1313 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Identity/Core/src/IdentityApiEndpointRouteBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ public static IEndpointConventionBuilder MapIdentityApi<TUser>(this IEndpointRou
var refreshTicket = refreshTokenProtector.Unprotect(refreshRequest.RefreshToken);

// Reject the /refresh attempt with a 401 if the token expired or the security stamp validation fails
// By design: we don't check whether the account is locked out. Locking out is
// password brute-force protection and is therefore irrelevant to check here.
// Refreshing the token doesn't force a sign-in.
if (refreshTicket?.Properties?.ExpiresUtc is not { } expiresUtc ||
timeProvider.GetUtcNow() >= expiresUtc ||
await signInManager.ValidateSecurityStampAsync(refreshTicket.Principal) is not TUser user)
Expand Down
Loading