Add continueOnError to UploadAstred task and install the Astred CLI - #17655
Open
akoeplinger wants to merge 2 commits into
Open
akoeplinger wants to merge 2 commits into
akoeplinger wants to merge 2 commits into
Conversation
Prevents the build from failing if something happens in the upload.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused pipeline change correctly implements the stated non-blocking upload behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Makes Astred digest uploads non-blocking so upload failures do not fail the build.
Changes:
- Enables
continueOnErrorfor theUploadAstred@0task.
| File | Description |
|---|---|
eng/common/core-templates/steps/astred-artifacts.yml |
Allows Astred upload failures without failing the build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akoeplinger
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the build from failing if something happens in the upload and installs the CLI even if some earlier step fails.
To double check: