[ci] Apply CFSClean environment settings - #1529
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0905f149-3491-4406-b7a0-7b5ad55786e8
There was a problem hiding this comment.
Pull request overview
Centralizes CI environment settings to reduce unwanted outbound network activity (revocation checks, update notifications, vulnerability/audit checks, telemetry, and template-triggered restores) so Azure builds remain compatible with CFSClean network isolation.
Changes:
- Added shared CI variables to disable .NET revocation checks, workload update notifications, SDK vulnerability checks, NuGet audit, and telemetry; also set
RUNNINGONCIglobally. - Removed the redundant step-level
RUNNINGONCIenv override from the CI build-and-test template. - Updated extended/allpackages tests to run
dotnet newwith--no-restore, deferring restore until after project modifications.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/extended/TestAllIndividualPackages.cs | Uses dotnet new ... --no-restore to avoid early restores before project edits. |
| tests/allpackages/TestAllIndividualPackages.cs | Same --no-restore change for the all-packages test project creation flow. |
| build/ci/variables.yml | Centralizes CI env/variables for revocation, workload notifications, vulnerability checks, NuGet audit, telemetry, and RUNNINGONCI. |
| build/ci/build-and-test.yml | Removes duplicate per-step RUNNINGONCI now that it’s set globally. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
jonathanpeppers
enabled auto-merge (squash)
August 18, 2026 19:17
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 18, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The shared CFSClean environment settings and no-restore template flow propagate correctly without breaking later restores or tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure builds can make unnecessary public network requests for certificate revocation, SDK update checks, vulnerability auditing, telemetry, and implicit template restores. Centralize the relevant CI settings to keep these operations compatible with CFSClean network isolation.
RUNNINGONCImarker globally and remove its duplicate step-level definition so Maven and Gradle paths consistently use the configured dnceng mirrors.--no-restoreto template creation because the generated projects are modified before their later build and restore.Validation:
tests/allpackages/AllPackagesTests.csprojandtests/extended/ExtendedTests.csproj.git diff --checkpasses.