[ci] Route API diff through dotnet-public - #1527
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/API-diff pipeline to consistently route NuGet package lookups through the repository’s canonical dotnet-public feed (as defined in NuGet.config), rather than letting individual tools fall back to direct NuGet.org traffic or duplicated inline feed configuration.
Changes:
- Read the
dotnet-publicpackage source from the rootNuGet.configand pass it explicitly todotnet api-tools nuget-diff. - Remove the duplicated CI variable for the workload feed URL.
- Ensure workload installation uses the root
NuGet.configvia--configfilein both Azure Pipelines and the GitHub workflow.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nuget-diff.cake |
Extracts dotnet-public from NuGet.config and passes it to api-tools nuget-diff via --source. |
build/ci/variables.yml |
Removes the now-redundant dotnetWorkloadSource variable. |
build/ci/setup-environment.yml |
Installs workloads using --configfile NuGet.config instead of an explicit --source variable. |
.github/workflows/copilot-setup-steps.yml |
Installs the Android workload using --configfile NuGet.config for consistent feed usage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
jonathanpeppers
enabled auto-merge (squash)
August 18, 2026 19:17
dalexsoto
approved these changes
Aug 18, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
API diff and workload setup now consistently use the canonical dotnet-public source and root NuGet configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API diff task performs package lookup independently of normal NuGet restore, causing direct traffic to NuGet.org despite the repository-level configuration.
This change reads the canonical
dotnet-publicsource fromNuGet.configand passes it explicitly toapi-tools nuget-diff. Workload installation paths now also use the root configuration, and the duplicated workload source variable has been removed.Validation:
nuget-diff.cakeagainst a real mirrored package and confirmed the generated command uses thedotnet-publicsource.git diff --check.