Skip to content

[ci] Stop lint Maven Central traffic - #1526

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-fix-gradle-maven-routing
Aug 18, 2026
Merged

[ci] Stop lint Maven Central traffic#1526
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-fix-gradle-maven-routing

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

AGP 8.12 lint's NewerVersionAvailable check bypasses configured Gradle repositories and contacts repo1.maven.org directly, leaving five Maven Central requests in every CI build.

Disable that networked advisory only when RUNNINGONCI=true in the five Gradle modules. Local developer builds retain the version check, while CI dependency resolution remains routed through dotnet-public-maven.

Validation

  • Full build completed for all four Gradle roots with a fresh Gradle cache
  • All 2,026 Gradle dependency-resolver requests targeted pkgs.dev.azure.com
  • Java debug traces contained zero repo1.maven.org requests
  • An isolated local run with RUNNINGONCI unset still made the expected lint metadata requests

Disable lint's NewerVersionAvailable check only in CI because AGP bypasses configured Gradle repositories and contacts repo1.maven.org directly.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 16:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents Android Gradle Plugin (AGP) 8.12 lint from making direct Maven Central (repo1.maven.org) network calls during CI by conditionally disabling the NewerVersionAvailable lint check when RUNNINGONCI=true, while preserving the advisory for local developer builds.

Changes:

  • Add android { lint { ... } } configuration to disable NewerVersionAvailable only when RUNNINGONCI=true.
  • Apply the same conditional lint configuration across five Gradle modules (Play extensions + Material extensions).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/com.google.android.play/feature.delivery.extensions/extensions-aar/build.gradle Conditionally disables NewerVersionAvailable lint check in CI to stop Maven Central traffic.
source/com.google.android.play/core.extensions/extensions-aar/build.gradle Extends existing lint { baseline = ... } config to also disable NewerVersionAvailable on CI.
source/com.google.android.play/asset.delivery.extensions/extensions-aar/build.gradle Conditionally disables NewerVersionAvailable lint check in CI to stop Maven Central traffic.
source/com.google.android.material/material.extensions/extensions-aar/build.gradle Conditionally disables NewerVersionAvailable lint check in CI to stop Maven Central traffic.
source/com.google.android.material/material.extensions/app/build.gradle Conditionally disables NewerVersionAvailable lint check in CI to stop Maven Central traffic.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 18, 2026 19:18
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint advisory is disabled only during CI, stopping Maven Central traffic while preserving local developer behavior.

@jonathanpeppers
jonathanpeppers merged commit c4b8b76 into main Aug 18, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-fix-gradle-maven-routing branch August 18, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants