Document Animation callbacks - #634
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #244 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 17, 2026 13:19
jonathanpeppers
enabled auto-merge (squash)
August 17, 2026 13:19
There was a problem hiding this comment.
Pull request overview
This PR improves the API reference XML documentation for Android.Views.Animations.Animation by replacing several remaining placeholder docs with meaningful descriptions, focusing on animation lifecycle callbacks and a few related properties/methods.
Changes:
- Documented
AnimationStart,AnimationRepeat, andAnimationEndevent summaries. - Replaced placeholder
<value>documentation forBackgroundColorandDetachWallpaper. - Replaced placeholder
<returns>documentation forComputeDurationHint().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #244 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Animationlifecycle callbacks plus values for animation duration, background color, and wallpaper detachment.Refs #244
Sources
Animation.java(callback, duration, and property documentation): https://android.googlesource.com/platform/frameworks/base/+/refs/heads/main/core/java/android/view/animation/Animation.javaValidation
[xml].Android.Views.AnimationsTo be addedplaceholders from 110 to 104;Animation.xmlretains only the two .NET infrastructureJniPeerMembersplaceholders.git diff --checkpassed.