Skip to content

Document MBMS download request metadata - #630

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-mbms-apis
Aug 18, 2026
Merged

Document MBMS download request metadata#630
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-mbms-apis

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Documented source-backed DownloadRequest metadata accessors and size limits in Android.Telephony.Mbms.
  • Corrected the size-limit descriptions to match the serialization paths used by the Android implementation.
  • Refs Add XML documentation for Android.Telephony.Mbms #245

Sources

Validation

  • Parsed docs/xml/Android.Telephony.Mbms/DownloadRequest.xml as XML.
  • Confirmed CRLF line endings with no lone LF characters.
  • Ran git diff --check.

Refs #245

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated XML documentation for Android.Telephony.Mbms.DownloadRequest, replacing several “To be added.” placeholders with concrete descriptions of metadata accessors and size limit properties.

Changes:

  • Added summaries/values for DestinationUri, FileServiceId, SourceUri, and SubscriptionId.
  • Filled in <value> documentation for the Max* size limit properties.
Suppressed comments (1)

docs/xml/Android.Telephony.Mbms/DownloadRequest.xml:309

  • The documentation for MaxDestinationUriSize currently describes the app's download-completion intent (Intent#toUri(int)), but getMaxDestinationUriSize() is the limit for the destination URI/path serialized via Uri#toString(). This appears swapped with MaxAppIntentSize and should be corrected (including the duplicated text).
        <summary>Maximum permissible length for the app's download-completion intent, when serialized via
            <c>Intent#toUri(int)</c>.</summary>
        <value>Maximum permissible length for the app's download-completion intent, when serialized via
            <c>Intent#toUri(int)</c>.</value>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Android.Telephony.Mbms/DownloadRequest.xml Outdated
Comment thread docs/xml/Android.Telephony.Mbms/DownloadRequest.xml Outdated
Refs #245

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MBMS download request contracts, URI behavior, and size-limit semantics now match Android.

@jonathanpeppers
jonathanpeppers merged commit 41c44ec into main Aug 18, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-mbms-apis branch August 18, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants