Document PrintAttributes builder options - #627
Merged
Merged
Conversation
Refs #180 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 17, 2026 02:27
jonathanpeppers
enabled auto-merge (squash)
August 17, 2026 02:27
There was a problem hiding this comment.
Pull request overview
This PR updates the generated XML documentation for Android.Print.PrintAttributes.Builder by replacing “To be added.” placeholders with meaningful docs for its five public configuration methods, aligning with established documentation structure (summary/param/returns + Android reference link + AOSP/CC BY attribution).
Changes:
- Documented parameters, summaries, and fluent return values for
SetColorMode,SetDuplexMode,SetMediaSize,SetMinMargins, andSetResolution. - Added per-member remarks linking to the corresponding Android reference documentation pages (with existing AOSP/CC BY attribution retained).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 17, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The PrintAttributes.Builder contracts correctly cover required arguments, validation, and fluent return behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the five public configuration methods on
Android.Print.PrintAttributes.Builder.Refs #180
Sources
Validation
docs/xml/Android.Print/PrintAttributes+Builder.xmlas XML.git diff --check.To be added.placeholders underdocs/xml/Android.Print.