Document network slice enum APIs - #615
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #240 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 16, 2026 16:06
jonathanpeppers
enabled auto-merge (squash)
August 16, 2026 16:06
There was a problem hiding this comment.
Pull request overview
Documents the public enum contracts for 5G network slicing and route selection in Android.Telephony.Data, replacing placeholder XML docs while preserving Android reference links and CC BY attribution.
Changes:
- Added
<summary>/<remarks>content (including upstream reference links and attribution) for three enum types. - Replaced member-level
To be added.summaries with specific descriptions for each enum value.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/xml/Android.Telephony.Data/RouteSelectionSscMode.xml | Adds enum/value documentation and attribution for SSC mode constants. |
| docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml | Adds enum/value documentation and attribution for session-type constants. |
| docs/xml/Android.Telephony.Data/NetworkSliceServiceType.xml | Adds enum/value documentation and attribution for network slice service-type constants. |
Suppressed comments (2)
docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml:82
- This summary says "both IP and IPV6"; for the Ipv4v6 session type it should explicitly refer to both IPv4 and IPv6, and use standard casing.
<summary>The route selection descriptor is for the session with both IP and IPV6 types.</summary>
docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml:110
- Use standard IPv6 casing in this summary (currently "IPV6").
<summary>The route selection descriptor is for the session with IPV6 type.</summary>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #240 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 16, 2026 16:30
Member
Author
|
@dalexsoto review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #240
Sources
Validation
git diff --check.To be addedcount is 0 anddocs/xml/index.xmlis untouched.