Skip to content

Document network slice enum APIs - #615

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-telephony-data-apis-5fe
Open

Document network slice enum APIs#615
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-telephony-data-apis-5fe

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Document the public 5G network-slice service-type, route session-type, and SSC-mode enum contracts.
  • Preserve Android reference links and CC BY attribution for the source material.

Refs #240

Sources

Validation

  • Parsed all three edited XML files with PowerShell's XML parser.
  • Confirmed CRLF line endings in each edited XML file.
  • Ran git diff --check.
  • Confirmed scoped To be added count is 0 and docs/xml/index.xml is untouched.

Refs #240

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the public enum contracts for 5G network slicing and route selection in Android.Telephony.Data, replacing placeholder XML docs while preserving Android reference links and CC BY attribution.

Changes:

  • Added <summary>/<remarks> content (including upstream reference links and attribution) for three enum types.
  • Replaced member-level To be added. summaries with specific descriptions for each enum value.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/xml/Android.Telephony.Data/RouteSelectionSscMode.xml Adds enum/value documentation and attribution for SSC mode constants.
docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml Adds enum/value documentation and attribution for session-type constants.
docs/xml/Android.Telephony.Data/NetworkSliceServiceType.xml Adds enum/value documentation and attribution for network slice service-type constants.
Suppressed comments (2)

docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml:82

  • This summary says "both IP and IPV6"; for the Ipv4v6 session type it should explicitly refer to both IPv4 and IPv6, and use standard casing.
        <summary>The route selection descriptor is for the session with both IP and IPV6 types.</summary>

docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml:110

  • Use standard IPv6 casing in this summary (currently "IPV6").
        <summary>The route selection descriptor is for the session with IPV6 type.</summary>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Android.Telephony.Data/RouteSelectionSessionType.xml Outdated
Refs #240

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and removed request for dalexsoto August 16, 2026 16:30
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants