Skip to content

Document Media Session playback flags - #613

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-media-session-docs
Open

Document Media Session playback flags#613
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-media-session-docs

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Document MediaController.Extras, local and remote playback types, and the public media-session handling flags.
  • Leave generated interop members and unscoped placeholders untouched.

Refs #137

Sources

Validation

  • Parsed all changed XML files with PowerShell's XML parser.
  • Confirmed CRLF line endings and git diff --check.
  • Reduced Android.Media.Session placeholders from 273 to 268.

Refs #137

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the generated XML documentation for Android.Media.Session by replacing a few remaining “To be added.” placeholders with meaningful summaries/values, focusing on media session playback flags, playback types, and MediaController.Extras.

Changes:

  • Documented MediaSessionFlags members for media button handling and transport controls.
  • Documented MediaPlaybackType values for local vs. remote playback.
  • Replaced the placeholder <value> text for MediaController.Extras.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/xml/Android.Media.Session/MediaSessionFlags.xml Replaces placeholder summaries for public media-session handling flags.
docs/xml/Android.Media.Session/MediaPlaybackType.xml Replaces placeholder summaries for local/remote playback type values.
docs/xml/Android.Media.Session/MediaController.xml Replaces placeholder value text for MediaController.Extras.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Android.Media.Session/MediaController.xml Outdated
Refs #137

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers requested review from dalexsoto and removed request for dalexsoto August 16, 2026 14:48
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two media-session blockers remain:

  • PlaybackInfo.PlaybackType is mapped to Android.Media.MediaPlaybackType (0/1) although Android returns session playback values 1/2; local values appear as remote and remote values are unnamed. Please correct the binding to Android.Media.Session.MediaPlaybackType and regenerate.
  • Both MediaSessionFlags members are deprecated no-ops since API 26, but their summaries describe active behavior and enum-field remarks are not published. Put the no-op/deprecation guidance directly in the summaries or generate matching obsolescence metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants