Document Media Session playback flags - #613
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Refs #137 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 16, 2026 14:37
jonathanpeppers
enabled auto-merge (squash)
August 16, 2026 14:38
There was a problem hiding this comment.
Pull request overview
This PR improves the generated XML documentation for Android.Media.Session by replacing a few remaining “To be added.” placeholders with meaningful summaries/values, focusing on media session playback flags, playback types, and MediaController.Extras.
Changes:
- Documented
MediaSessionFlagsmembers for media button handling and transport controls. - Documented
MediaPlaybackTypevalues for local vs. remote playback. - Replaced the placeholder
<value>text forMediaController.Extras.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/xml/Android.Media.Session/MediaSessionFlags.xml | Replaces placeholder summaries for public media-session handling flags. |
| docs/xml/Android.Media.Session/MediaPlaybackType.xml | Replaces placeholder summaries for local/remote playback type values. |
| docs/xml/Android.Media.Session/MediaController.xml | Replaces placeholder value text for MediaController.Extras. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #137 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 16, 2026 14:48
Member
Author
|
@dalexsoto review |
dalexsoto
requested changes
Aug 17, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
Two media-session blockers remain:
PlaybackInfo.PlaybackTypeis mapped toAndroid.Media.MediaPlaybackType(0/1) although Android returns session playback values1/2; local values appear as remote and remote values are unnamed. Please correct the binding toAndroid.Media.Session.MediaPlaybackTypeand regenerate.- Both
MediaSessionFlagsmembers are deprecated no-ops since API 26, but their summaries describe active behavior and enum-field remarks are not published. Put the no-op/deprecation guidance directly in the summaries or generate matching obsolescence metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MediaController.Extras, local and remote playback types, and the public media-session handling flags.Refs #137
Sources
Validation
git diff --check.Android.Media.Sessionplaceholders from 273 to 268.