Repository navigation
Validate localized authentication resources in Abstractions builds - #4819
Draft
paulmedynski wants to merge 1 commit into
Draft
paulmedynski wants to merge 1 commit into
paulmedynski wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The parameterization is correctly wired, preserves existing behavior, and has focused regression coverage.
0 open findings
What changed in this PR
Adds reusable localization validation for Abstractions while preserving existing SqlClient validation.
Changes:
- Parameterizes resource paths and allowlist sections.
- Adds Abstractions validation and an independent allowlist.
- Adds Pester coverage for selection and pipeline wiring.
| File | Description |
|---|---|
validate-localization-step.yml |
Accepts explicit validation inputs. |
validate-localization.ps1 |
Selects the requested allowlist section. |
validate-localization.Tests.ps1 |
Tests section selection and rejection. |
pipeline-invocation.Tests.ps1 |
Verifies template contracts and wiring. |
build-buildproj-job.yml |
Enables Abstractions validation. |
onebranch-pipeline-design.instructions.md |
Documents both validation gates. |
LocalizationValidationAllowlist.json |
Adds the Abstractions allowlist section. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameterize localization validation and activate it for Abstractions in official package builds.
Layer 5 of 6 in the seven-PR phase-one authentication stack.
Issues
No issue is automatically closed by this localization infrastructure layer.
Testing
pwsh -NoProfile -Command 'Import-Module Pester -MinimumVersion 5.0; $c = New-PesterConfiguration; $c.Run.Path = @("./eng/pipelines/onebranch/scripts/tests/validate-localization.Tests.ps1", "./eng/pipelines/onebranch/scripts/tests/pipeline-invocation.Tests.ps1"); $c.Run.Exit = $true; $c.Output.Verbosity = "Minimal"; Invoke-Pester -Configuration $c'— passed, 43 tests. Six new checks failed as expected before implementation.pwsh -NoProfile -File eng/pipelines/onebranch/scripts/validate-localization.ps1 -ResourcesDirectory src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Resources -AllowlistPath .config/LocalizationValidationAllowlist.json -AllowlistSection AbstractionsAllowedEnglishValueMatches— passed, 13 cultures, 5 keys, no English-value exceptions.pwsh -NoProfile -File eng/pipelines/onebranch/scripts/validate-localization.ps1 -ResourcesDirectory src/Microsoft.Data.SqlClient/src/Resources -AllowlistPath .config/LocalizationValidationAllowlist.json— failed with 13 pre-existing findings:ADP_IsolationLevelResetTimeoutis untranslated in all 13 cultures.mainworktree at332e17fe76c8fe7c5ed0de0e77835ca8223f7c7d.git diff --check— passed.Official pipeline execution was not triggered.
Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Tests added or updated.
Public API changes documented — no public API changes.
Verified against customer repro — no customer repro applies.
Ensure no breaking changes introduced — existing driver validation behavior is preserved.