Repository navigation
Validate installed SqlClient family versions from Logging packages - #4815
Draft
paulmedynski wants to merge 1 commit into
Draft
paulmedynski wants to merge 1 commit into
paulmedynski wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Project-specific legacy packages configuration files currently bypass validation.
2 open findings
What changed in this PR
Adds consumer-side validation ensuring installed SqlClient family packages use identical versions.
Changes:
- Ships validation through
build/andbuildTransitive/. - Adds extensive synthetic and package-consumer tests.
- Documents diagnostics and the emergency opt-out.
| File | Description |
|---|---|
BUILDGUIDE.md |
Documents validation and testing. |
Logging.targets |
Implements family-version checks. |
Logging.csproj |
Packages the targets. |
PackageReadme.md |
Documents consumer behavior. |
RunVersionChecks.ps1 |
Adds the regression matrix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+39
to
+41
| <XmlPeek XmlInputPath="$(MSBuildProjectDirectory)/packages.config" | ||
| Query="/packages/package[@id='Microsoft.Data.SqlClient.Internal.Logging']/@version" | ||
| Condition="Exists('$(MSBuildProjectDirectory)/packages.config')"> |
| @@ -0,0 +1,53 @@ | |||
| <Project> | |||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/paul/aot/phase-1.0 #4815 +/- ##
=========================================================
Coverage ? 65.10%
=========================================================
Files ? 286
Lines ? 68600
Branches ? 0
=========================================================
Hits ? 44665
Misses ? 23935
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Ship exact installed-family package validation from Internal.Logging, in both
build/andbuildTransitive/.packages.config, including prerelease labels,SQLCLIENT001diagnostics, design-time skipping and the emergencySqlClientEnforceFamilyVersions=falseopt-out.Layer 1 of 6 in the seven-PR phase-one authentication stack; based on the branch-guidance layer. No authentication implementation changes.
Issues
No issue is automatically closed by this infrastructure layer.
Testing
pwsh -NoProfile -File src/Microsoft.Data.SqlClient.Internal/Logging/test/RunVersionChecks.ps1— passed, 503 checked dotnet commands.packages.config.build/andbuildTransitive/targets.git -C ../phase-1.1 diff --check— passed before commit.No SQL Server or identity service was required.
Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Tests added or updated.
Public API changes documented — no public API changes.
Verified against customer repro — no customer repro applies.
Ensure no breaking changes introduced — mixed installed family versions intentionally fail with an explicit emergency opt-out.