Skip to content

[6.1] Localize authority parsing error - #4807

Open
cheenamalhotra wants to merge 1 commit into
dev/cheena/backport-pr-4521-6-1from
dev/cheena/6-1-authority-localization
Open

cheenamalhotra wants to merge 1 commit into
dev/cheena/backport-pr-4521-6-1from
dev/cheena/6-1-authority-localization

Conversation

@cheenamalhotra

@cheenamalhotra cheenamalhotra commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Add SQL_InvalidAuthority to all 13 satellite resource files for the authority parsing fix in #4791. Each file receives the exact three-line neutral resource entry immediately after SQL_UnsupportedAuthentication, preserving {0}, xml:space="preserve", XML escaping, encoding, and existing content.

This PR is stacked on #4791 and targets dev/cheena/backport-pr-4521-6-1, not release/6.1 directly. Following the source-string pattern used in #4803, the values remain English pending normal localization. No changes to the neutral resource, designer, implementation, public APIs, documentation, or tests. No unrelated resources are imported from main. The diff is exactly 13 files and 39 added lines, with no deletions.

Issues

Testing

No automated test source was created or modified. The existing functional localization test exercises a different connection error, not this resource key. Driver builds and unrelated unit/integration suites were not run because this change only adds satellite XML entries; focused XML, parity, preservation, and diff validation cover the requested change.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 23:21
@cheenamalhotra
cheenamalhotra requested a review from a team as a code owner October 8, 2026 23:21
@cheenamalhotra
cheenamalhotra added this pull request to stack #4808 October 8, 2026 23:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All 13 entries are well-formed and exactly match the neutral resource value, attributes, and placement.

0 open findings

What changed in this PR

Adds the authority-validation error resource to all 13 localized satellite files for the 6.1 backport.

Changes:

  • Adds SQL_InvalidAuthority with the neutral English value.
  • Preserves placeholder, XML escaping, attributes, and resource ordering.
File Description
Strings.cs.resx Adds Czech satellite entry.
Strings.de.resx Adds German satellite entry.
Strings.es.resx Adds Spanish satellite entry.
Strings.fr.resx Adds French satellite entry.
Strings.it.resx Adds Italian satellite entry.
Strings.ja.resx Adds Japanese satellite entry.
Strings.ko.resx Adds Korean satellite entry.
Strings.pl.resx Adds Polish satellite entry.
Strings.pt-BR.resx Adds Brazilian Portuguese satellite entry.
Strings.ru.resx Adds Russian satellite entry.
Strings.tr.resx Adds Turkish satellite entry.
Strings.zh-Hans.resx Adds Simplified Chinese satellite entry.
Strings.zh-Hant.resx Adds Traditional Chinese satellite entry.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cheenamalhotra cheenamalhotra added this to the 6.1.8 milestone Oct 8, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 8, 2026 23:25
@cheenamalhotra
cheenamalhotra force-pushed the dev/cheena/6-1-authority-localization branch from 66fb41f to 3120c85 Compare October 8, 2026 23:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All 13 entries match the neutral resource exactly, and every modified XML resource parses successfully.

0 open findings

🧠 Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants