Repository navigation
[6.1.8 Cherry-pick] Add evidence-based SqlClient code review skill - #4776
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
cheenamalhotra
force-pushed
the
dev/automation/pr-4736-to-6.1.8
branch
from
October 6, 2026 06:19
a971ac0 to
17405d0
Compare
cheenamalhotra
changed the title
* Add evidence-based SqlClient code review skill Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Restore read-only tool scope for code review prompt Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Adapt mssql-rs review lessons for SqlClient Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Pin code review guidance to trusted policy sources Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 (cherry picked from commit 5508773) Copilot-Session: fff89c9a-4d27-447a-9fea-dd53c0b233c8
cheenamalhotra
force-pushed
the
dev/automation/pr-4736-to-6.1.8
branch
from
October 6, 2026 06:42
17405d0 to
becc7db
Compare
cheenamalhotra
marked this pull request as ready for review
October 6, 2026 07:12
cheenamalhotra
requested review from
a team
and
a balanced review from Copilot
October 6, 2026 07:12
Member
|
Not needed. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several instructions and repository paths do not exist or differ on release/6.1.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Backports the evidence-based SqlClient review skill to release/6.1.
Changes:
- Adds the review workflow and publication safeguards.
- Adds driver-specific checks and reporting guidance.
- Documents pinned external sources.
| File | Description |
|---|---|
SKILL.md |
Defines the review workflow. |
references/sources.md |
Records guidance sources. |
references/reporting.md |
Defines reporting and publication rules. |
references/driver-checks.md |
Adds SqlClient-specific review checks. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| narrower scope, and do not inspect ignored secret/configuration files. | ||
| 3. Read trusted repository instructions, [review policy](../../../policy/review-process.md), | ||
| [coding practices](../../../policy/coding-best-practices.md), and the applicable | ||
| `.github/instructions/` guides. Use the actual reviewed revision's project |
| | Surface | Starting point | | ||
| | --- | --- | | ||
| | Driver implementation | `src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/` | | ||
| | Public API and build selection | `src/Microsoft.Data.SqlClient/ref/`, implementation/ref `.csproj` files and imported build files | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of commit 5508773 (#4736) onto
release/6.1.Only one cherry-picked commit; no source-branch merges or additional adaptations. The four added skill files are unchanged from the source commit. Conflicts preserve the release branch's existing instructions and absent files.