Repository navigation
[7.0.4 Cherry-pick] Add evidence-based SqlClient code review skill - #4774
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
cheenamalhotra
force-pushed
the
dev/automation/pr-4736-to-7.0.4
branch
from
October 6, 2026 06:18
d1213f8 to
b1e96de
Compare
cheenamalhotra
changed the title
* Add evidence-based SqlClient code review skill Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Restore read-only tool scope for code review prompt Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Adapt mssql-rs review lessons for SqlClient Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 * Pin code review guidance to trusted policy sources Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e511be1-16f3-4ab0-a8d3-51efbde72763 (cherry picked from commit 5508773) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: adde8699-2df7-4719-bfa5-c33dabcfc592
cheenamalhotra
force-pushed
the
dev/automation/pr-4736-to-7.0.4
branch
from
October 6, 2026 06:42
b1e96de to
def9ee8
Compare
cheenamalhotra
marked this pull request as ready for review
October 6, 2026 07:10
cheenamalhotra
requested review from
a team
and
a balanced review from Copilot
October 6, 2026 07:10
cheenamalhotra
previously approved these changes
Oct 6, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two references are broken on this branch, and the guidance incorrectly states that actively built legacy project trees are unused.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Cherry-picks the evidence-based SqlClient review skill into release/7.0 and updates agent guidance.
Existing feedback: One human approval, no review threads, and Copilot review in progress.
Changes:
- Adds review workflow, reporting, source, and driver-check guidance.
- Replaces the legacy review prompt with the new skill.
- Updates public API and unified-project documentation.
| File | Description |
|---|---|
AGENTS.md |
Directs reviews to the new skill. |
.github/skills/sqlclient-code-review/SKILL.md |
Defines the review workflow. |
.github/skills/sqlclient-code-review/references/sources.md |
Records pinned guidance sources. |
.github/skills/sqlclient-code-review/references/reporting.md |
Defines reporting and publication gates. |
.github/skills/sqlclient-code-review/references/driver-checks.md |
Adds SqlClient-specific review checks. |
.github/prompts/implement-feature.prompt.md |
Updates reference-source guidance. |
.github/prompts/fix-bug.prompt.md |
Updates reference-source guidance. |
.github/prompts/code-review.prompt.md |
Removes the superseded prompt. |
.github/instructions/architecture.instructions.md |
Documents the unified project layout. |
.github/instructions/api-design.instructions.md |
Updates API-surface paths. |
.github/copilot-instructions.md |
Updates repository architecture guidance. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulmedynski
requested changes
Oct 6, 2026
paulmedynski
left a comment
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
The Copilot feedback seems legit.
Document active legacy build and API comparison projects while keeping new sources in the unified directories. Replace missing test and secrets guidance references with existing release-branch documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
paulmedynski
approved these changes
Oct 9, 2026
Contributor
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
paulmedynski
enabled auto-merge (squash)
October 9, 2026 13:22
cheenamalhotra
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4736 (5508773) into
release/7.0.Conflicts resolved using the original commit's contents. No release-specific wording or link changes.