Skip to content

Fix agentic triage comment submission and reject incomplete summaries #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyankatiwari08 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix agentic triage comment submission and reject incomplete summaries #4706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd3482c
Fix agentic triage safe-output submission
priyankatiwari08 Sep 17, 2026
1dd3d32
Merge origin/main and reject incomplete triage summaries
priyankatiwari08 Sep 25, 2026
c761da2
Address triage validator review feedback
priyankatiwari08 Sep 28, 2026
5c0393d
Reject marker-prefixed triage drafts and document validation intent
priyankatiwari08 Oct 5, 2026
213ee33
Close triage validation ordering and incomplete-output gaps
priyankatiwari08 Oct 8, 2026
0f31cc7
Allow comparison prose in triage validation
priyankatiwari08 Oct 9, 2026
fd13931
Preserve generic and XML syntax in triage summaries
priyankatiwari08 Oct 9, 2026
af74dd4
Validate triage heading without stripping indentation
priyankatiwari08 Oct 12, 2026
42d95c2
Enforce triage label state and reject remaining unfinished output
priyankatiwari08 Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/scripts/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,37 @@
# GitHub Actions Script Tests

## Agentic triage output tests

`validate-triage-output.test.cjs` uses the built-in Node.js test runner (Node.js
20 or newer). No npm dependencies are needed. Run it from the repository root:

```bash
node --test .github/scripts/tests/validate-triage-output.test.cjs
```

These tests also run in `verify-aw-lock.yml`. They cover the validation gate
before triage comments and labels are published: complete summaries, explicit
no-op/failure results, placeholder comments, unfinished templates, quoted/fenced
examples, duplicate comments, and mixed success/incomplete outcomes.
They also reject partial safe-output batches with recorded errors while
allowing C# generic type syntax in completed summaries. Draft prefixes such as
`TODO:` and `TBD:` are rejected in required fields and list items; ordinary
mentions of those markers within completed prose remain valid.
Coverage also includes multiline template placeholders, label operations queued
before the summary, and contradictory no-op/incomplete results.
Comparison operators in completed prose remain valid; angle-bracket detection
targets known template fields and instructions rather than arbitrary bracketed text.
Generic arguments such as `Task<Result>` and `List<Item>`, including nested
types, and XML documentation tags are covered by acceptance regressions.
The summary heading must start at the beginning of the body; leading indentation
cannot turn a code-block heading into an accepted Markdown heading.
Initial and follow-up summaries must queue exactly one Waiting for Author label
operation matching the Environment row; on-demand summaries must leave labels
unchanged. Tests also reject diagnostic placeholders within required fields,
duplicate required rows/sections, and unfinished content in additional prose.

## Shell script tests

This directory contains tests for the shell scripts used by the
[cherry-pick-hotfix](./../../../.github/workflows/cherry-pick-hotfix.yml),
[check-milestone](./../../../.github/workflows/check-milestone.yml) and
Expand Down
Loading
Loading