Skip to content

Jj/the big gm pr#2528

Draft
jurrejelle wants to merge 63 commits into
doldecomp:masterfrom
jurrejelle:jj/the-big-gm-pr
Draft

Jj/the big gm pr#2528
jurrejelle wants to merge 63 commits into
doldecomp:masterfrom
jurrejelle:jj/the-big-gm-pr

Conversation

@jurrejelle
Copy link
Copy Markdown
Collaborator

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented May 23, 2026

Report for GALE01 (66afaf4 - ade8b7f)

📈 Matched code: 68.42% (+0.00%, +180 bytes)
📈 Matched data: 39.76% (+0.00%, +24 bytes)

✅ 2 new matches
Unit Item Bytes Before After
main/melee/gm/gmallstar gm_801B59AC +69 72.68% 100.00%
main/melee/gm/gmopening .rodata +24 0.00% 100.00%
🥀 1 broken match
Unit Item Bytes Before After
main/melee/gm/gmcamera gmCamera_801A3634_OnEnter -72 100.00% 0.00%
📈 18 improvements in unmatched items
Unit Item Bytes Before After
main/melee/gm/gm_1BA8 gm_801BC00C +933 0.00% 81.32%
main/melee/gm/gm_1BA8 gm_801BB758 +731 0.00% 94.28%
main/melee/gm/gm_1BA8 gm_801BF128 +645 0.00% 89.67%
main/melee/gm/gm_1BA8 gm_801BCC9C +612 0.00% 95.05%
main/melee/gm/gm_1BA8 gm_801BBB64 +602 0.00% 72.02%
main/melee/gm/gmopening gm_801A9DD0 +316 0.00% 62.30%
main/melee/gm/gm_1BA8 gm_801BD028 +271 0.00% 85.81%
main/melee/gm/gmcamera gmCamera_801A33BC +212 31.09% 97.31%
main/melee/gm/gm_1BA8 gm_801BAC9C +186 0.00% 87.85%
main/melee/gm/gmallstar gm_801B5624 +149 78.45% 94.99%
main/melee/gm/gmallstar gm_801B5ACC +43 79.89% 84.53%
main/melee/gm/gmresult fn_801771C0 +21 80.77% 85.63%
main/melee/gm/gm_18A5 fn_80190ABC +5 88.61% 89.19%
main/melee/gm/gm_18A5 fn_8018A514 +4 90.72% 91.11%
main/melee/gm/gm_1BA8 .sdata2 +3 75.00% 88.89%
main/melee/gm/gmcamera gmCamera_801A253C +2 87.91% 89.63%
main/melee/gm/gmcamera gmCamera_801A292C +1 73.16% 73.24%
main/melee/gm/gmallstar gm_801B5324 0 74.51% 74.53%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
main/melee/gm/gmresult gm_80177368_OnEnter -115 99.25% 86.85%
main/melee/gm/gmopening .sdata2 -4 50.00% 40.00%

jurrejelle and others added 30 commits May 23, 2026 21:05
The gm_1601 stub-matching work was extracted into its own branch
(jj/gm_1601_claude, based on master) for a focused PR. This branch keeps
the remaining gm/ work (gm_1BA8, gm_18A5, gmallstar, gmcamera, gmopening,
gmresult, lbbgflash).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… feasible

Convert dont_inline to func_noinline inline-wrapper stacks for multi-call
helpers (gmresult/gm_1BA8/gmcamera/lbbgflash). Keep dont_inline only where
wrappers provably can't work: single-call helpers (they inline regardless
of wrapper depth) and gm_18A5's broad-region pragmas (one on/reset pair
spans ~dozens of functions). No match regressions.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant