feat: add human-friendly report presentation [CMP-48642] - #64
Merged
Conversation
github-actions
Bot
added
documentation
yariv-doit
reviewed
Aug 11, 2026
yariv-doit
reviewed
Aug 11, 2026
chaim0m
changed the base branch from
feat/chaim/report-result-shaping-CMP-48642
to
main
August 11, 2026 13:43
chaim0m
force-pushed
the
feat/chaim/report-presentation-CMP-48642
branch
from
August 11, 2026 13:48
d929285 to
21b43e9
Compare
yariv-doit
reviewed
Aug 11, 2026
|
|
||
| if viper.GetBool("pivot-rows") { | ||
| if pivoted, ok := pivotReportBody(rows, schema); ok { | ||
| if shouldPivotReportRows() { |
Collaborator
There was a problem hiding this comment.
🟡 Medium: preserve the --max-rows contract for pivots
Returning the pivot here bypasses effectiveMaxRows() below, so both the agent-mode default cap and an explicit --max-rows are silently ignored whenever pivoting succeeds. Reproducing with 20 unique groups and --pivot --max-rows 10 emits 21 rows (20 groups plus totals), despite the flag promising a maximum number of report rows.
Please calculate totals from the complete input, then limit the emitted non-total pivot rows while preserving the totals and reporting the omitted count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
https://doitintl.atlassian.net/browse/CMP-48642
Summary
Extracts the human report-presentation portion of doiteng/omni#60609. Stacked on #63.
Changes
Currency is attached only when the request or response explicitly provides it; the CLI does not assume USD when config.currency is omitted.
Testing
No emulators were used.
Dependency
Merge #63 first, then retarget this PR to main.