feat(jats): embed local figure images - #4041
Open
teachershuang wants to merge 2 commits into
Open
Conversation
Signed-off-by: teachershuang <guhongkaiailaopo@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @teachershuang, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: teachershuang <guhongkaiailaopo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<fig><graphic xlink:href="...">elements in file-based JATS documentsImageRefvalues on the generatedPictureItemwhile preserving captionsPart of #3583.
Testing
conda run -n docling-contrib python -m pytest -q tests/test_backend_jats.py(42 passed)pytest-cov(8 passed; every executable line added injats_backend.pycovered)conda run -n docling-contrib python -m pytest -q tests/test_backend_optional_dependencies.py tests/test_input_doc.py(29 passed)prekhooks: trailing whitespace, EOF, merge conflict, large files, Ruff lint/format, ty, Tach, module coverage, and 1500-line limitorigin/main; the changed-file 1500-line hook passesScope
Remote URL fetching, inline graphics, and nested
<alternatives>graphics remain out of scope for this focused change.Checklist: