fix: avoid false PR failures for unpublished release links - #97
Merged
Merged
Conversation
Keep exact changelog release URLs in the live check while reporting their pre-publication 404s as notices only for distribution-version PRs. Signed-off-by: Arnaud Héritier <arnaud.heritier@docker.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
![docker-gordon[bot]](https://avatars.githubusercontent.com/in/5032340?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Downgrades are incorrectly treated as releases, and the changelog includes an unrelated unsupported claim.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates the external-link checker to tolerate unpublished release links during release PRs.
Changes:
- Downgrades qualifying release-link 404s to notices.
- Tracks redirects and validates catalog versions.
- Adds regression tests and documentation.
| File | Description |
|---|---|
scripts/check_external_links.py |
Implements release-link exceptions. |
scripts/test_check_external_links.py |
Tests release-link handling. |
README.md |
Documents checker behavior. |
CHANGELOG.md |
Records user-visible changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Only treat strictly newer distribution versions as unpublished releases, and remove unrelated Claude metadata notes from this PR. Signed-off-by: Arnaud Héritier <arnaud.heritier@docker.com>
gtardif
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release:prepareemitsCHANGELOG.mdcompare/tag links before the newly bumped release version (for example,v0.3.1) exists. On release PR #96,external-linkstherefore reports two expected 404s.In PR
--basemode, narrowly downgrade only an exact, unredirected HTTP 404 for a current newly bumped catalog version referenced byCHANGELOG.mdto a notice. The links are still fetched. Wrong URLs/files/versions, redirects, 410s, unrelated links, and full-sweep checks remain errors.Tests added;
task validateandtaskpassed.Context: #96