Repository navigation
Fix partial redaction of Slack and Stripe tokens, plus detection and CLI bugs #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+707
−171
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ff60334
fix: redact the whole Slack token, not just its first segment
dgageot e5c2a9a
fix: redact full-length Stripe secret and restricted keys
dgageot 850d877
fix: detect Discord bot tokens for every snowflake prefix
dgageot 26cf3fb
fix: never report the redaction marker as a secret
dgageot 984d5cd
fix(scan): scan pipes and FIFOs instead of reporting them clean
dgageot 59f8a89
fix(scan): anchor -ignore patterns that start with a slash
dgageot b6debab
test: make the Bedrock known-token case exercise the Bedrock rule
dgageot 87ed3b9
perf: gate the three PII rules with one pass over the input
dgageot 6a0022a
fix: match IBAN letters as ASCII only, like the rule's gate
dgageot 8e4b1b2
docs: document Find, the []byte variants and portcullis-scan
dgageot 025cb21
docs: fix the README example, which no longer redacted anything
dgageot 15d7b79
docs: put the compiledRule comment on compiledRule
dgageot 4e3732d
simplify: drop a Bedrock key length check that cannot fail
dgageot f2890f6
fix(scan): keep a match on one line when its path has a line break
dgageot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two files named
a\nbanda bproduce the same displayed path after this replacement. If both contain a secret at the same position, the output no longer identifies which file needs attention. Escape line breaks in paths instead of replacing them with spaces, and escape the escape character so the original path remains recoverable.Comment
@docker-gordon helpto see review commands.Finding
f-65cb5146f414076b82a78dfa