Repository navigation
Conversation
crazy-max
marked this pull request as ready for review
November 5, 2026 14:17
crazy-max
force-pushed
the
output-compression
branch
from
November 5, 2026 15:34
54229e0 to
c3bcd98
Compare
crazy-max
force-pushed
the
output-compression
branch
from
November 16, 2026 15:34
c3bcd98 to
b99143c
Compare
tonistiigi
reviewed
Nov 17, 2026
tonistiigi
left a comment
Member
There was a problem hiding this comment.
ignored with a warning for local output.
Where would that warning come from?
| connection_id: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }} | ||
| scope: 'dhi.io@pull' | ||
|
|
||
| build-compression: |
Member
There was a problem hiding this comment.
Is there any "expected" conditions for these test, that would fail if things are not working.
Member
Author
There was a problem hiding this comment.
Member
Author
That was left over from an earlier version. I removed the warning and updated the PR description. Compression settings are ignored for local output. |
crazy-max
force-pushed
the
output-compression
branch
from
November 17, 2026 09:21
b99143c to
030bef8
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
output-compression
branch
from
November 17, 2026 18:58
030bef8 to
1f9973c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #207
closes #333
Add
compression,compression-level, andforce-compressioninputs to both workflows so callers can configure image layer compression, including recompressing existing base image layers with zstd. Omitted settings preserve BuildKit's defaults. Compression settings apply only to image output and are ignored for local output.Use the shared exporter helper from docker/actions-toolkit#1397 to construct the exporter once and share it across the build matrix, replacing duplicated exporter construction.