Repository navigation
Conversation
Credential guidance implied that mechanism presence alone grants approval and that custom secrets always replace header placeholders. Require approved destinations for each mechanism and explain authentication header stripping on denied kit routes.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The credential guide described routing internals instead of explaining what readers need to approve. Put separate API key and OAuth domain approvals next to the binding example and explain how denied requests affect custom secrets.
The credential guide repeated kit scope and mixed approval concepts. Explain the domain lists beside the example and state what happens to custom secrets in blocked authentication headers.
Credential approval applies regardless of kit schema version. Refer to kits without a v2 qualifier in the inherited-credential guidance.
dvdksn
marked this pull request as ready for review
November 20, 2026 15:39
craig-osterhout
approved these changes
Nov 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that credential bindings must approve destinations separately for API keys and OAuth, and that bindings with no destinations are treated as missing. Document the exception for custom secrets in authentication headers on kit routes denied by binding approval.
Validation: the changed page passes rumdl and Vale. Runtime tests could not run because the installed Go toolchain is older than the required version.