Repository navigation
Conversation
Custom secret guidance did not explain which headers receive credentials. Document explicit and default header bindings, migration steps, and the limits of response redaction.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Describe custom secrets in terms of current behavior and link to the settings reference for default headers. Remove migration details and format rejected headers as a list.
An older running daemon cannot apply default headers to custom secrets. Document the API requirement, the effect of credential synchronization, and the restart needed after an upgrade.
The header configuration guide interrupted normal usage with daemon compatibility details. Move recovery steps to troubleshooting, anchored to the reported error, and omit internal API versions.
The response filtering guidance leaves readers to interpret its limits and the meaning of a WebSocket upgrade. Explain when filtering applies, what it recognizes, and how its limits affect clients.
The custom secret troubleshooting section describes a client and daemon version mismatch after an upgrade. Remove this recovery scenario from the guide because upgrades restart the daemon.
dvdksn
marked this pull request as ready for review
November 20, 2026 15:38
Explain how header defaults and minimum length affect existing secrets, align HTTPS substitution wording, and shorten the proxy-controlled header reference.
dvdksn
added a commit
that referenced
this pull request
Nov 20, 2026
Leave the shared custom-secret paragraph to PR #26715 so the HTTPS and header-binding updates can merge without overwriting each other. The HTTPS requirement remains documented in the injection overview.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain how to bind local custom secrets to request headers and configure
secret.custom.defaultHeaders. Add migration guidance for existing secrets, the eight-character minimum, and response-redaction limits so users can update their authentication setup.Validation: scoped Markdown and Vale checks passed. Command examples were reviewed against source and tests; runtime verification was unavailable.