Repository navigation
fix: stabilize debug-tool test against windows shell flake - #4524
Merged
Merged
Conversation
trungutt
approved these changes
Oct 5, 2026
aheritier
added
area/cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four Windows CI runs failed in
TestDebugToolCommand/selected_agent_and_deferred_toolwith empty-output 30s timeouts, and the same commit passed on a same-commit rerun, pointing at an intermittent hang in the native shell invocation rather than a logic bug. The exact Windows-side cause of the shell timeout was never pinned down, and native Windows wasn't run locally to confirm it, so this avoids guessing at a shell fix and instead removes the flaky dependency from this particular test case.The deferred-tool fixture for the
helperagent now uses thefilesystemtoolset restricted toread_multiple_filesinstead ofshell. The test still exercises the same selected-agent/deferred-tool dispatch path it was written for, just through a different helper-only tool, and it asserts the realhello.txtcontent, wrong-agent rejection, and catalog ownership/schema the same way the shell version did.TestDebugToolsetsCommand_IncludesDeferredToolswas tightened similarly, now asserting the deferred tool is owned byhelperspecifically rather than just discoverable somewhere in the output.Shell execution itself is still covered by other tests in this file, so no coverage is lost; this just stops one specific assertion from depending on a real shell process on Windows. No production code changed, no timeout was bumped, and nothing was skipped on Windows. This is unrelated to the TUI changes in #4523.